Skip to content

Commit

Permalink
Add Appraisal install to the setup script (#1621)
Browse files Browse the repository at this point in the history
1. Fork the repo
2. Follow instructions in CONTRIBUTING.md
3. Step 3 fails, because
```
$ bundle exec appraisal rspec
Could not find gem 'administrate-field-image' in any of the gem sources
listed in your Gemfile.
Run `bundle install` to install missing gems.
```

It looks like the previous step installs project dependencies, but does
not install version specific dependencies from `./gemfiles/*` required
from appraisal gem to run specs against specific rails versions.

The `gemfiles` setup is managed with `appraisal`, hence it should run
its installation process before executing tests.
  • Loading branch information
kdelchev committed Apr 29, 2020
1 parent 043e7c6 commit a156352
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions bin/setup
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ set -e
gem install bundler --conservative
bundle check || bundle install

bundle exec appraisal install

# Set up configurable environment variables
if [ ! -f .env ]; then
cp .sample.env .env
Expand Down

0 comments on commit a156352

Please sign in to comment.