include time for date_time field in index #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 1, 2018
| locals: { field: date_time, namespace: "admin" }, | ||
| ) | ||
| end | ||
| end |
There was a problem hiding this comment.
Layout/TrailingBlankLines: Final newline missing.
| ) | ||
|
|
||
| render( | ||
| partial: "fields/date_time/index.html.erb", |
There was a problem hiding this comment.
Layout/FirstParameterIndentation: Indent the first parameter one step more than the start of the previous line.
| date_time = instance_double( | ||
| "Administrate::Field::DateTime.with_options(format: #{Time::DATE_FORMATS[:default]})", | ||
| data: product, | ||
| datetime: product.created_at |
There was a problem hiding this comment.
Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.
| it "renders date_time" do | ||
| product = create(:product) | ||
| date_time = instance_double( | ||
| "Administrate::Field::DateTime.with_options(format: #{Time::DATE_FORMATS[:default]})", |
There was a problem hiding this comment.
Layout/FirstParameterIndentation: Indent the first parameter one step more than the start of the previous line.
Metrics/LineLength: Line is too long. [95/80]
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#710
Just modifies the index view template for the date_time field to display the time (as well as the date) as is being done in the show template.