Tables won't always be named after models

[pablobm]

Alternative to #1264.
Fixes #1179.

Currently, Administrate::Search::Query makes the assumption that an association's table name will have the same name as the association attribute, ignoring a :class_name option that signals otherwise.

This change uses the :class_name option when given.

Changing the example app also provides a way to test this as part of the existing feature specs.

[pablobm]

@sedubois @ksearfos @bjgaynor - Would you be able to check if this fixes your issues? Thank you.

[sedubois]

@pablobm I tried to load the branch in my project as follows:

# Gemfile
gem 'administrate', git: 'https://github.com/pablobm/administrate.git', branch: 'association-search-table-name'

But I get

$ bundle 
Fetching https://github.com/pablobm/administrate.git
fatal: Could not parse object 'b2cb529f710915bb12ade19b2b9cd6ca30f5496a'.
Revision b2cb529f710915bb12ade19b2b9cd6ca30f5496a does not exist in the repository https://github.com/pablobm/administrate.git. Maybe you
misspelled it?

Any idea what I might be doing wrong?

[pablobm]

That's strange. It looks to me like a GitHub issue. I upgraded from Administrate 0.12 to 0.13 on a dummy app and it installed the SHA that your setup claims to be missing:

Using administrate 0.12.0 (was 0.13.0) from https://github.com/pablobm/administrate.git (at association-search-table-name@b2cb529)

That SHA is also present on Github at pablobm@b2cb529

Perhaps try going back to 0.12, bundle, then 0.13 again? Or wiping out the gem from your machine and trying again. For example, in my machine it's at ~/.asdf/installs/ruby/2.6.5/lib/ruby/gems/2.6.0/bundler/gems/administrate-b2cb529f7109. I use asdf, so it will be different with rbenv, RVM, etc.

[sedubois]

@pablobm no luck but as a workaround I cloned your branch and used gem 'administrate', path: '~/Repos/administrate-pablobm'.

I encountered one issue: association_search? expects the field to be HasOne, HasMany or BelongsTo, but my field is NestedHasMany. It seems to be fixed as follows:

# lib/administrate/search.rb

    def association_search?(attribute)
      return unless attribute_types[attribute].respond_to?(:deferred_class)
      
      attribute_types[attribute].deferred_class < Administrate::Field::Associative
    end

EDIT: updated code above which contained an error.

EDIT2: this is actually the same problem that happened in base_controller.rb as discussed here, there seems to be an opportunity to DRY up the code.

[sedubois]

@pablobm I updated previous comment, with that change now the search works for me 🎉

[sedubois]

@pablobm also this PR seems partly duplicate of #1203. Would it be possible to integrate the changes it contains to support multiple association search fields (searchable_fields array)?

[pablobm]

Uh, I thought I had merged a fix for this some time ago. Turns out I hadn't: #1398 Merged now.

That other PR I just merged takes a bit more of a heavy-handed approach. I like your solution using < instead. Would you be up for a separate MR that refactors that method, and also the following (mentioned on the PR) to use your approach?

administrate/lib/administrate/base_dashboard.rb

Lines 76 to 80 in acada05

	def association_classes
	@association_classes ||=
	ObjectSpace.each_object(Class).
	select { |klass| klass < Administrate::Field::Associative }
	end

As for this PR here, I just rebased it. Would you be able to check that the problem is actually fixed now?

[sedubois]

@pablobm I confirm the search now works for my Post::Translation associations of type NestedHasMany without any extra modifications (tested with gem 'administrate', github: 'pablobm/administrate', branch: 'association-search-table-name').

I've also created PR #1576.

[pablobm]

Thank you @sedubois!