git_source substitution doesn't work with nested groups #159
Comments
BrianHawley
added a commit
to BrianHawley/appraisal
that referenced
this issue
Oct 3, 2019
- Also make install spec less specific about generated option order. - Ignore .ruby-version and .ruby-gemset to ease local development. [Fixes thoughtbot#159]
BrianHawley
added a commit
to BrianHawley/appraisal
that referenced
this issue
Oct 3, 2019
- Also make install spec less specific about generated option order. - Ignore .ruby-version and .ruby-gemset to ease local development. [Fixes thoughtbot#159]
BrianHawley
added a commit
to BrianHawley/appraisal
that referenced
this issue
Oct 26, 2019
- Ignore .ruby-version and .ruby-gemset to ease local development. [Fixes thoughtbot#159]
nickcharlton
pushed a commit
to BrianHawley/appraisal
that referenced
this issue
Feb 10, 2020
- Ignore .ruby-version and .ruby-gemset to ease local development. [Fixes thoughtbot#159]
nickcharlton
pushed a commit
to BrianHawley/appraisal
that referenced
this issue
Feb 10, 2020
If you declare a `git_source` at the top level of your Gemfile or a spec in Appraisals, it will substitute the gem source in `gem` declarations. If you want to use those gem sources in nested groups declared with `group`, `platforms`, `platform`, `source`, `git`, or `path`, the `git_source` declarations from the top level aren't inherited, so they don't work like they do with bundler. Fortunately, in `BundlerDSL` there's a protected `git_sources` writer, and all the groups are also declared in that file. It should be easy enough to assign all of the group objects to a copy of the `git_sources`. That would make the substitutions work. Fixes thoughtbot#159.
nickcharlton
pushed a commit
that referenced
this issue
Feb 10, 2020
If you declare a `git_source` at the top level of your Gemfile or a spec in Appraisals, it will substitute the gem source in `gem` declarations. If you want to use those gem sources in nested groups declared with `group`, `platforms`, `platform`, `source`, `git`, or `path`, the `git_source` declarations from the top level aren't inherited, so they don't work like they do with bundler. Fortunately, in `BundlerDSL` there's a protected `git_sources` writer, and all the groups are also declared in that file. It should be easy enough to assign all of the group objects to a copy of the `git_sources`. That would make the substitutions work. Fixes #159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you declare a
git_sourceat the top level of your Gemfile or a spec in Appraisals, it will substitute the gem source ingemdeclarations. If you want to use those gem sources in nested groups declared withgroup,platforms,platform,source,git, orpath, thegit_sourcedeclarations from the top level aren't inherited, so they don't work like they do with bundler.Fortunately, in
BundlerDSLthere's a protectedgit_sourceswriter, and all the groups are also declared in that file. It should be easy enough to assign all of the group objects to a copy of thegit_sources. That would make the substitutions work.The text was updated successfully, but these errors were encountered: