Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make git_source work in nested groups #160

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Make git_source work in nested groups #160

merged 1 commit into from
Feb 10, 2020

Conversation

BrianHawley
Copy link
Contributor

  • Also make install spec less specific about generated option order.
  • Ignore .ruby-version and .ruby-gemset to ease local development.

[Fixes #159]

@BrianHawley BrianHawley force-pushed the fixes_159 branch 5 times, most recently from ab598db to aed9f37 Compare October 4, 2019 00:28
@hound hound bot deleted a comment from BrianHawley Feb 10, 2020
@BrianHawley @nickcharlton
Make git_source work in nested groups
a88ea24 
If you declare a `git_source` at the top level of your Gemfile or a spec in
Appraisals, it will substitute the gem source in `gem` declarations. If you
want to use those gem sources in nested groups declared with `group`,
`platforms`, `platform`, `source`, `git`, or `path`, the `git_source`
declarations from the top level aren't inherited, so they don't work like they
do with bundler.

Fortunately, in `BundlerDSL` there's a protected `git_sources` writer, and all
the groups are also declared in that file. It should be easy enough to assign
all of the group objects to a copy of the `git_sources`. That would make the
substitutions work.

Fixes thoughtbot#159.
@nickcharlton
Copy link
Member

Thanks! I rebased onto master after merging #158 and removed the gitignore, but otherwise this is as is. I'm going to merge this now.

@nickcharlton nickcharlton merged commit a904a4a into thoughtbot:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git_source substitution doesn't work with nested groups
2 participants
@BrianHawley @nickcharlton