Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relativizing directory on remotes that do not represent a path #205

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Fix relativizing directory on remotes that do not represent a path #205

merged 1 commit into from
Feb 6, 2023

Commits on Feb 6, 2023

  1. Fix relativizing directory on non-path remotes 

    Appraisal was creating invalid lock files, because paths weren't being
relatived correctly. e.g.:

    remote: https://github.com/thoughtbot..raisal

Instead of:

    remote: https://github.com/thoughtbot/appraisal

This PR solves this issue by replacing only the absolute paths that are
preceded by a space.
    @aymeric-ledorze @nickcharlton
    aymeric-ledorze authored and nickcharlton committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    f31bc34 View commit details
    Browse the repository at this point in the history