Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petergoldstein
Copy link

As Travis CI.org has been inactive since mid-2021, appraisal has not had CI for quite some time. This PR is an attempt to migrate CI to GitHub actions.

It is not green, and I'm looking for help on getting it there. The current failures are all bundler install issues. Is anyone more familiar with the internals of the appraisal gem able to give me some guidance on how to get the bundle install --local in the various specs to pass? Do we need to set an environment variable? Or is this unrelated to current work?

@nickcharlton
Copy link
Member

Thanks!

I've got a branch I've been working on that I'd mentioned in #204 that I've been looking at over the last week or so: https://github.com/thoughtbot/appraisal/actions/workflows/main.yml

Have you been getting the same failures?

@petergoldstein
Copy link
Author

@nickcharlton I hadn't seen your branch. I'm getting similar, but not exactly the same failures. And unlike you, I don't have any jobs running green. I'm running everything on the most recent bundler that the underlying Ruby supports.

Based on what I'm seeing on your branch (specifically the passing 3.0 and 3.1), I think that some of the deprecation issues are coming into play with bundler 2.4.x. Specifically these:

DEPRECATED] The `--path` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local path 'vendor/another'`, and stop using this flag
[DEPRECATED] The `--without` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local without 'drinks'`, and stop using this flag

I think the code in lib/appraisal/appraisal.rb needs to be updated to use the config approach to get recent bundlers to pass. This may also require an additional reset in the test code - I haven't looked yet.

If I get some time that's the approach I'm going to take next.

@kyrofa kyrofa mentioned this pull request Feb 23, 2023
@petergoldstein petergoldstein force-pushed the feature/migrate_to_github_actions branch from 6b26e78 to ee09714 Compare April 10, 2023 14:29
This replaces the previous Travis CI (no longer active) with GitHub Actions.

It adds a bunch of more recent Rubies (3.0, 3.1, 3.2, JRuby 9.3, JRuby 9.4) to the CI matrix.
@nickcharlton nickcharlton force-pushed the feature/migrate_to_github_actions branch from ee09714 to 0e9efac Compare July 14, 2023 14:31
@nickcharlton
Copy link
Member

nickcharlton commented Jul 14, 2023

I just rebased it to see if I could get the tests to run here as me, but apparently not :( which eventually seems to be running.

@pboling
Copy link
Contributor

pboling commented Apr 25, 2024

I was able to get Appraisal & Combustion working on a massive test matrix (Ruby 2.3 - 3.3, Rails 3.0 - 7.1, bundler 1 - 2) here: pboling/sanitize_email@a9c1d9a

It might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants