Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests due to missing shoulda dependency #28

Closed
wants to merge 1 commit into from
Closed

Fix failing tests due to missing shoulda dependency #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Expand Up @@ -41,6 +41,7 @@ GEM
rspec-expectations (2.6.0)
diff-lcs (~> 1.1.2)
rspec-mocks (2.6.0)
shoulda (2.11.3)
term-ansicolor (1.0.6)

PLATFORMS
Expand All @@ -51,3 +52,4 @@ DEPENDENCIES
aruba (~> 0.4.2)
cucumber (~> 1.0)
rspec (~> 2.6)
shoulda (~> 2.11.3)
1 change: 1 addition & 0 deletions appraisal.gemspec
View file
Open in desktop
Expand Up @@ -23,4 +23,5 @@ Gem::Specification.new do |s|
s.add_development_dependency('cucumber', '~> 1.0')
s.add_development_dependency('rspec', '~> 2.6')
s.add_development_dependency('aruba', '~> 0.4.2')
s.add_development_dependency('shoulda', '~> 2.11.3')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Appraisal only depends on shoulda-matchers, not shoulda itself - could you change it to shoulda-matchers instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I replace shoulda with shoulda-matchers the tests fail.
https://github.com/thoughtbot/appraisal/blob/master/features/gemspec.feature asking for shoulda explicitly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. What if you change that feature to use shoulda-matchers too? Would that work? I'd like to have the most specific dependency possible, and not pulling in shoulda-context would be great.

end