Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make relativize task available #50

Closed
wants to merge 1 commit into from

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jun 15, 2013

@grosser
Copy link
Contributor Author

grosser commented Jul 12, 2013

bump, any chance I can get this in as a temp-fix ?

sikachu added a commit that referenced this pull request Aug 9, 2013
sikachu added a commit that referenced this pull request Sep 4, 2013
@sikachu
Copy link
Contributor

sikachu commented Sep 4, 2013

After some consideration, I don't think I'm going to pull this in for now, as I'm not going to have a minor release on 0.x anymore. I really would like to thank you for your contribution, and your patience.

I'm going to run this cleanup stuff automatically when you do appraisal install from 1.0 upward. So, if you don't mind, please give 1.0.0.rc1 a test when it's out.

@sikachu sikachu closed this Sep 4, 2013
sikachu added a commit that referenced this pull request Sep 4, 2013
sikachu added a commit that referenced this pull request Sep 4, 2013
sikachu added a commit that referenced this pull request Sep 4, 2013
sikachu added a commit that referenced this pull request Sep 13, 2013
sikachu added a commit that referenced this pull request Sep 19, 2013
@phillbaker
Copy link
Contributor

@sikachu would love to give 1.0.0.rc1 a whirl. What else needs to get done for that release?

@sikachu
Copy link
Contributor

sikachu commented Oct 1, 2013

@phillbaker I was thinking about adding more support for bundler syntax (#47, #48, and #51) ... but I think I'll cut out a beta earlier than that just to play around with the CLI.

@phillbaker
Copy link
Contributor

@sikachu would love a beta! Interested in trying it out on https://github.com/assaf/vanity.

@sikachu
Copy link
Contributor

sikachu commented Oct 30, 2013

a month ago.

@phillbaker I'm really sorry for the delay, but I've released 1.0.0.beta1. Would you mind give it a try when you have a chance?

@phillbaker
Copy link
Contributor

@sikachu no worries!

I'll give it a go, should help with fewer updates to the gemfiles/*.

@phillbaker
Copy link
Contributor

@sikachu probably want this on another thread/issue, but quick find:

I get a Bundler could not find compatible versions for gem "thor": when trying to rake appraisal:install for an Appraisal file

appraise "rails3" do
  gem "rails", "~> 3.0.11"
end

Probably because of

Is it possible to relax the thor requirements for appraisal? Otherwise it looks like rails 3.0.0 - 3.2.3 won't bundle (other gems with a dependency on thor would probably also be effected).

@sikachu
Copy link
Contributor

sikachu commented Oct 30, 2013

Great finding! I was being careless on setting the requirement. Let me see if I can reduce the version requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rake appraisal:relativize
3 participants