Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h* font size variables and margin #60

Merged
merged 1 commit into from
Jun 13, 2014
Merged

Add h* font size variables and margin #60

merged 1 commit into from
Jun 13, 2014

Conversation

whmii
Copy link
Contributor

@whmii whmii commented May 23, 2014

A proposition for consistent bottom margin across headers.
(this could be extended further to replace the multiple iterations $base-line-height / 2)

@kylefiedler
Copy link
Contributor

@whmii when designing for apps I've never had consistent margin on the bottom of my headers. I felt like leaving it off caused less confusion for me when building out the rest of the site.

I like putting the h* sizes in variables though. I'm not crazy about those names though. I don't really like the way http://typeplate.com/ names them either.

@whmii
Copy link
Contributor Author

whmii commented Jun 6, 2014

Agreed, font-size variables can really help standardize things. I will modify the pr and repost…
Still having issues with the variable names if anyone has any sugestions

@tysongach
Copy link
Contributor

@whmii @kylefiedler From a higher level, I think this raises an interested point: I believe we should state somewhere in the readme that Bitters is geared more towards creating apps, and not ‘marketing websites’. This isn’t to say that one can’t use Bitters for a regular marketing website, but with this clarification, the reasoning behind removing margins and other visual features would make more sense. Just a little sprinkle of purpose…

@kylefiedler
Copy link
Contributor

@tysongach Agree, I created a issue to track that #70

kylefiedler added a commit that referenced this pull request Jun 13, 2014
Add h* font size variables and margin
@kylefiedler kylefiedler merged commit 9a65b3e into master Jun 13, 2014
@whmii whmii deleted the wm-headersize branch July 11, 2014 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants