Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

Commit

Permalink
Fix failing Cucumber test, update Aruba, Cucumber
Browse files Browse the repository at this point in the history
By having the `@disable-bundler` hook, the `bourbon` command was not
being found in the tests. Our theory is that this is due to a change in
the `@disable-bundler` hook that improves isolation of gems defined in
the `Gemfile.lock` when working within a gem.

Co-authored-by: Ian Zabel <ian@thoughtbot.com>
Co-authored-by: Tyson Gach <tyson@tysongach.com>
  • Loading branch information
tysongach and Ian Zabel committed Jun 1, 2018
1 parent 838dc5b commit 1500a5b
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 9 deletions.
3 changes: 2 additions & 1 deletion bourbon.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ $:.push File.expand_path("../lib", __FILE__)
require "bourbon/version"

Gem::Specification.new do |s|
s.add_development_dependency "aruba", "~> 0.6.2"
s.add_development_dependency "aruba", "~> 0.14"
s.add_development_dependency "css_parser", "~> 1.4"
s.add_development_dependency "cucumber", "~> 2.0"
s.add_development_dependency "rake", "~> 11.1"
s.add_development_dependency "rspec", "~> 3.4"
s.add_development_dependency "scss_lint", "0.48"
Expand Down
1 change: 0 additions & 1 deletion features/install.feature
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@disable-bundler
Feature: Install bourbon files

Scenario: Bourbon generates a new bourbon installation
Expand Down
10 changes: 6 additions & 4 deletions features/step_definitions/bourbon_steps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,19 @@
"bourbon/validators",
]
sass_directories.map!{ |directory| bourbon_path(prefix, directory) }
check_directory_presence(sass_directories, true)
sass_directories.each do |sass_directory|
expect(sass_directory).to be_an_existing_directory
end
end

Then /^the master bourbon partial should have been generated(?: within "([^"]+)" directory)?$/ do |prefix|
check_file_presence([bourbon_path(prefix, '_bourbon.scss')], true)
expect(bourbon_path(prefix, "_bourbon.scss")).to be_an_existing_file
end

Then /^bourbon should not have been generated$/ do
check_directory_presence(['bourbon'], false)
expect("bourbon").not_to be_an_existing_directory
end

Then /^the output should contain the current version of Bourbon$/ do
assert_exact_output("Bourbon #{Bourbon::VERSION}\n", all_output)
expect(last_command_started).to have_output "Bourbon #{Bourbon::VERSION}"
end
1 change: 0 additions & 1 deletion features/update.feature
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@disable-bundler
Feature: Update bourbon files

Scenario: Updating updates an existing bourbon install
Expand Down
2 changes: 0 additions & 2 deletions features/version.feature
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
@disable-bundler
Feature: Show version
Scenario: Viewing version
When I successfully run `bundle exec bourbon --version`
Then the output should contain the current version of Bourbon

0 comments on commit 1500a5b

Please sign in to comment.