This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Fix for issue #208 #238
Closed
Fix for issue #208 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONFIG['host_os'] will return the underlying OS no matter what the ruby platform is.
|
Did you see: |
|
You're right, that does seem to be almost the exact same thing. Any idea what the delay is on getting this fix merged? |
|
Don't know. Looks like it's been dark here since Dec. 6, 2011. |
|
#221 has been merged into master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem with building when using jruby, because RUBY_PLATFORM is 'java'. This causes the case statement to always assume the OS is OSX, which obviously fails on anything that isn't OSX.
I'm not sure what the best process is for fixing problems with build scripts; I'm not aware of any way to test it other than simply trying the build on every supported platform. I've only been able to try it on linux ree, linux jruby, and OSX 1.9.2.