Fix for issue #208 #238

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

This fixes a problem with building when using jruby, because RUBY_PLATFORM is 'java'. This causes the case statement to always assume the OS is OSX, which obviously fails on anything that isn't OSX.

I'm not sure what the best process is for fixing problems with build scripts; I'm not aware of any way to test it other than simply trying the build on every supported platform. I've only been able to try it on linux ree, linux jruby, and OSX 1.9.2.

@Fitzsimmons Fitzsimmons Fix for issue #208
CONFIG['host_os'] will return the underlying OS no matter what the ruby platform is.
deabcc0
Contributor

pgieser commented Jan 12, 2012

Did you see:

#221

You're right, that does seem to be almost the exact same thing. Any idea what the delay is on getting this fix merged?

Contributor

pgieser commented Jan 12, 2012

Don't know. Looks like it's been dark here since Dec. 6, 2011.

Contributor

halogenandtoast commented Jan 13, 2012

#221 has been merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment