Skip to content
This repository has been archived by the owner on Nov 18, 2017. It is now read-only.
This repository has been archived by the owner on Nov 18, 2017. It is now read-only.

Other authentication methods #196

Closed
2 of 3 tasks
pbrisbin opened this issue Mar 24, 2015 · 5 comments
Closed
2 of 3 tasks

Other authentication methods #196

pbrisbin opened this issue Mar 24, 2015 · 5 comments

Comments

@pbrisbin
Copy link
Contributor

@pbrisbin pbrisbin added this to the Paid beta milestone Mar 24, 2015
@pbrisbin
Copy link
Contributor Author

pbrisbin commented Apr 7, 2015

Adding Twitter to yesod-auth-oauth2: freckle/yesod-auth-oauth2#27

@pbrisbin
Copy link
Contributor Author

pbrisbin commented Apr 7, 2015

Adding Google to carnival: #212

@pbrisbin pbrisbin removed this from the Announcement milestone Apr 11, 2015
@pbrisbin
Copy link
Contributor Author

I'm going to consider this done for now. We won't be adding Twitter since it doesn't provide an Email. If folks feels strongly about providing FB, we can add a new issue for it.

@jferris
Copy link
Contributor

jferris commented Apr 13, 2015

It's too bad Twitter is such a pain. I feel like that's the most likely one people will use. Is there a way to get people to "finalize" OAuth2 logins, so that they enter an email after authenticating with Twitter?

Or, could we make email nullable? Is that a bad path to go down?

@pbrisbin
Copy link
Contributor Author

We could probably add a custom screen to get an email from the user as part of on-boarding. I'm not sure what this'd look like or how difficult it'd be. I'd definitely prefer not to make userEmail a Maybe, but it's not the end of the world if the other options are too complicated. As of now, that would really just mean handling gravatars and notifications differently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants