Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_password_resets config option #1019

Merged

Conversation

whatnotery
Copy link
Contributor

solves #993

added config option to disallow password reset routes in cases where its not needed. allow_password_resets defaults to true but can be set to false in instances where it is not needed.

@whatnotery whatnotery requested a review from sej3506 as a code owner May 8, 2024 18:43
Gemfile Outdated Show resolved Hide resolved
config/routes.rb Show resolved Hide resolved
config/routes.rb Show resolved Hide resolved
lib/clearance/configuration.rb Show resolved Hide resolved
spec/configuration_spec.rb Show resolved Hide resolved
spec/routing/clearance_routes_spec.rb Show resolved Hide resolved
spec/routing/clearance_routes_spec.rb Show resolved Hide resolved
spec/routing/clearance_routes_spec.rb Show resolved Hide resolved
spec/routing/clearance_routes_spec.rb Show resolved Hide resolved
spec/routing/clearance_routes_spec.rb Show resolved Hide resolved
Copy link
Contributor

@sej3506 sej3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the contribution and the awesome spec coverage!

@sej3506 sej3506 merged commit dbfe55d into thoughtbot:main Aug 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants