Don't declare helper_method if the method is not supported #748
Conversation
Eg. ActionController::API does not support helper_method
spec/support/http_method_shim.rb
Outdated
| end | ||
|
|
||
| def post(path, params=nil, headers=nil) | ||
| super(path, params: params, headers: headers) | ||
| def post(path, params=nil) |
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
spec/support/http_method_shim.rb
Outdated
| end | ||
|
|
||
| def put(path, params=nil, headers=nil) | ||
| super(path, params: params, headers: headers) | ||
| def put(path, params=nil) |
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
spec/support/http_method_shim.rb
Outdated
| @@ -3,16 +3,16 @@ | |||
| # supported in Rails 5+. Since we support back to 3.1, we need some sort of shim | |||
| # to avoid super noisy deprecations when running tests. | |||
| module HTTPMethodShim | |||
| def get(path, params=nil, headers=nil) | |||
| super(path, params: params, headers: headers) | |||
| def get(path, params=nil) | |||
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
spec/clearance/controller_spec.rb
Outdated
| it "exposes no action methods" do | ||
| expect(controller.action_methods).to be_empty | ||
| if defined?(ActionController::API) | ||
| context 'included within ActionController::API' do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/clearance/controller_spec.rb
Outdated
| @@ -1,11 +1,25 @@ | |||
| require "spec_helper" | |||
|
|
|||
| describe Clearance::Controller, type: :controller do | |||
| controller(ActionController::Base) do | |||
| include Clearance::Controller | |||
| context 'included within ActionController::Base' do | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/support/http_method_shim.rb
Outdated
| end | ||
|
|
||
| def post(path, params=nil, headers=nil) | ||
| super(path, params: params, headers: headers) | ||
| def post(path, params=nil) |
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
spec/support/http_method_shim.rb
Outdated
| end | ||
|
|
||
| def put(path, params=nil, headers=nil) | ||
| super(path, params: params, headers: headers) | ||
| def put(path, params=nil) |
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
spec/support/http_method_shim.rb
Outdated
| @@ -3,16 +3,16 @@ | |||
| # supported in Rails 5+. Since we support back to 3.1, we need some sort of shim | |||
| # to avoid super noisy deprecations when running tests. | |||
| module HTTPMethodShim | |||
| def get(path, params=nil, headers=nil) | |||
| super(path, params: params, headers: headers) | |||
| def get(path, params=nil) | |||
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
spec/clearance/controller_spec.rb
Outdated
| it "exposes no action methods" do | ||
| expect(controller.action_methods).to be_empty | ||
| if defined?(ActionController::API) | ||
| context 'included within ActionController::API' do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/clearance/controller_spec.rb
Outdated
| @@ -1,11 +1,25 @@ | |||
| require "spec_helper" | |||
|
|
|||
| describe Clearance::Controller, type: :controller do | |||
| controller(ActionController::Base) do | |||
| include Clearance::Controller | |||
| context 'included within ActionController::Base' do | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/clearance/controller_spec.rb
Outdated
| include Clearance::Controller | ||
| end | ||
|
|
||
| it 'exposes no action methods' do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/clearance/controller_spec.rb
Outdated
| include Clearance::Controller | ||
| end | ||
|
|
||
| it 'exposes no action methods' do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/clearance/controller_spec.rb
Outdated
| include Clearance::Controller | ||
| end | ||
|
|
||
| it 'exposes no action methods' do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/clearance/controller_spec.rb
Outdated
| include Clearance::Controller | ||
| end | ||
|
|
||
| it 'exposes no action methods' do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/clearance/controller_spec.rb
Outdated
| include Clearance::Controller | ||
| end | ||
|
|
||
| it 'exposes no action methods' do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/clearance/controller_spec.rb
Outdated
| include Clearance::Controller | ||
| end | ||
|
|
||
| it 'exposes no action methods' do |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
…troller This required: * Dropping header support from the http_method_shim. Rails 5 does not have an equivalent argument * Explicitly adding rails-controller-testing as an external dependency * Bumping to rspec-rails ~>3.5, as earlier versions do not support Rails 5
|
Thank you. Simplified and merged as 56443e6. I will release soon (hopefully by Friday at the latest). |
Eg. ActionController::API does not support helper_method