This repository has been archived by the owner on Jun 8, 2019. It is now read-only.
Rework the job creation flow #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creuter
force-pushed
the
jd-reflow
branch
2 times, most recently
from
1f4aca5
to
8c8ca6e
Compare
|
Code looks good. Like the script a lot more. Why just applications and web? |
|
Yeah, we don't need that close. Removing. |
| end | ||
|
|
||
| defp connected_trix_input(form, field_name) do | ||
| [label(form, field_name), |
There was a problem hiding this comment.
Any reason you're switching to this syntax?
There was a problem hiding this comment.
Moved quickly and didn't look at it. I'm going to fix it now, thanks!
|
One question/comment. Otherwise LGTM |
|
|
||
| def trix_input(form, field_name, attrs \\ []) do | ||
| connected_trix_input(form, field_name) ++ | ||
| trix_tag(field_name, attrs) |
There was a problem hiding this comment.
Maybe indent this, or keep it on one line so it's not lost that you're appending these?
drapergeek
force-pushed
the
jd-reflow
branch
2 times, most recently
from
3d88d41
to
a437bba
Compare
* Allow a preview step * Add links for publishing * Show the edit/delete options on the show page if the job was looked up by token
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Rework the job flow to include a preview step #27