This repository has been archived by the owner on Jun 8, 2019. It is now read-only.
Visual design refinements #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the markup changes are removing wrapping |
creuter
force-pushed
the
cr-desktop-illustration
branch
from
67104bc
to
7943f85
Compare
| </section> | ||
| </header> | ||
|
|
||
| <img class="banner-image" src="<%= static_path(@conn, "/images/illustration.svg") %>"> |
| > | ||
| <li class="dribbble" data-role="dribbble-shot" style="display:none"> | ||
| <a class="dribbble-link" href="#"> | ||
| <img class="dribbble-img" src=""> |
| </section> | ||
| <ol class="section-content" data-role="meetup-list"> | ||
| <li class="meetup-slat" data-role="meetup"> | ||
| <h4 class="meetup-name" data-role="group-name">Meetup Group Name</h4> |
| } | ||
|
|
||
| @include media($grid-breakpoint) { | ||
| display: grid; |
There was a problem hiding this comment.
Do have need for a fallback or are you comfortable using CSS Grid only? Do you know what the layout looks like without CSS Grid?
There was a problem hiding this comment.
I'm comfortable with it, it's a website for designers. It's still readable without it, though, basically just a scaled up mobile view
* Use CSS Grid for layout * Add homepage illustration
creuter
force-pushed
the
cr-desktop-illustration
branch
from
7943f85
to
bbf02c6
Compare
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small:
Medium:
Large: