This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Add settings page #196
Merged
Add settings page #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert user.name == "Roger Murdoch" | ||
| refute user.auto_subscribe | ||
| refute user.daily_digest | ||
| end |
There was a problem hiding this comment.
A basic test for the show page might be good too
There was a problem hiding this comment.
Assert 200 is fine?
BlakeWilliams
force-pushed
the
bmw-tc-show-settings
branch
from
25d7ec1
to
86e5031
Compare
|
Looks good |
BlakeWilliams
force-pushed
the
bmw-tc-show-settings
branch
from
93316dc
to
426202d
Compare
Closed
This adds the settings page where users can update their name and subscription preferences.
BlakeWilliams
force-pushed
the
bmw-tc-show-settings
branch
from
426202d
to
36e7a69
Compare
|
OMG CI IS GREEN |
|
Merge it! 🚢 |
|
And congrats @tute on your first Constable PR :) |
|
Thanks, Paul! :) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the settings page where users can update their name and
subscription preferences.
@tute and I paired on this one.