-
-
Notifications
You must be signed in to change notification settings - Fork 205
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use latest EmberCLI-generated asset files
Closes [#298] Use Sprockets-generated manifest to detect which files are the most up to date versions of EmberCLI-generated assets. No longer support Sprockets-based helpers for Rails 3.2, given the difference in how the Asset Pipeline works post-4.0. [#298]: #298
- Loading branch information
1 parent
7dabfa5
commit 692623b
Showing
8 changed files
with
260 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
module EmberCli | ||
class Assets | ||
def initialize(app_name:, ember_app_name:, manifest:, prefix:) | ||
@app_name = app_name | ||
@ember_app_name = ember_app_name | ||
@prefix = prefix | ||
@manifest = manifest | ||
end | ||
|
||
def javascripts | ||
if empty_manifest? | ||
fallback_assets | ||
else | ||
[ | ||
latest_matching(%r{#{app_name}/assets/vendor(.*)\.js\z}), | ||
latest_matching(%r{#{app_name}/assets/#{ember_app_name}(.*)\.js\z}), | ||
] | ||
end | ||
end | ||
|
||
def stylesheets | ||
if empty_manifest? | ||
fallback_assets | ||
else | ||
[ | ||
latest_matching(%r{#{app_name}/assets/vendor(.*)\.css\z}), | ||
latest_matching(%r{#{app_name}/assets/#{ember_app_name}(.*)\.css\z}), | ||
] | ||
end | ||
end | ||
|
||
private | ||
|
||
attr_reader :app_name, :ember_app_name, :manifest, :prefix | ||
|
||
def fallback_assets | ||
["#{app_name}/assets/vendor", "#{app_name}/assets/#{ember_app_name}"] | ||
end | ||
|
||
def empty_manifest? | ||
files.empty? | ||
end | ||
|
||
def latest_matching(regex) | ||
file, = files. | ||
select { |key, _| key =~ regex }. | ||
sort_by { |_, data| data["mtime"] }. | ||
last | ||
|
||
[prefix, file].join("/") | ||
end | ||
|
||
def files | ||
manifest.files | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
module EmberCli | ||
class MissingManifest | ||
def files | ||
{} | ||
end | ||
|
||
def assets | ||
{} | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
require "ember_cli/assets" | ||
|
||
describe EmberCli::Assets do | ||
describe "#javascripts" do | ||
it "includes the most recent javascript build artifacts" do | ||
manifest = build_manifest( | ||
files: { | ||
"not-a-match" => {}, | ||
"foo/assets/bar-abc123.js" => { "mtime" => 1.day.ago.iso8601 }, | ||
"foo/assets/bar-def456.js" => { "mtime" => 2.days.ago.iso8601 }, | ||
"foo/assets/vendor-def456.js" => { "mtime" => 2.days.ago.iso8601 }, | ||
"foo/assets/vendor-abc123.js" => { "mtime" => 1.day.ago.iso8601 }, | ||
}, | ||
) | ||
assets = build_assets( | ||
app_name: "foo", | ||
ember_app_name: "bar", | ||
manifest: manifest, | ||
prefix: "assets", | ||
) | ||
|
||
javascripts = assets.javascripts | ||
|
||
expect(javascripts).to match_array([ | ||
"assets/foo/assets/bar-abc123.js", | ||
"assets/foo/assets/vendor-abc123.js", | ||
]) | ||
end | ||
|
||
context "when the manifest is empty" do | ||
it "falls back to the default assets" do | ||
assets = build_assets( | ||
manifest: build_empty_manifest, | ||
app_name: "foo", | ||
ember_app_name: "bar", | ||
) | ||
|
||
javascripts = assets.javascripts | ||
|
||
expect(javascripts).to match_array([ | ||
"foo/assets/vendor", | ||
"foo/assets/bar", | ||
]) | ||
end | ||
end | ||
end | ||
|
||
describe "#stylesheets" do | ||
it "includes the most recent stylesheet build artifacts" do | ||
manifest = build_manifest( | ||
files: { | ||
"not-a-match" => {}, | ||
"foo/assets/bar-def456.css" => { "mtime" => 2.days.ago.iso8601 }, | ||
"foo/assets/bar-abc123.css" => { "mtime" => 1.day.ago.iso8601 }, | ||
"foo/assets/vendor-abc123.css" => { "mtime" => 1.day.ago.iso8601 }, | ||
"foo/assets/vendor-def456.css" => { "mtime" => 2.days.ago.iso8601 }, | ||
}, | ||
) | ||
assets = build_assets( | ||
app_name: "foo", | ||
ember_app_name: "bar", | ||
manifest: manifest, | ||
prefix: "assets", | ||
) | ||
|
||
stylesheets = assets.stylesheets | ||
|
||
expect(stylesheets).to match_array([ | ||
"assets/foo/assets/bar-abc123.css", | ||
"assets/foo/assets/vendor-abc123.css", | ||
]) | ||
end | ||
|
||
context "when the manifest is empty" do | ||
it "falls back to the default assets" do | ||
assets = build_assets( | ||
manifest: build_empty_manifest, | ||
app_name: "foo", | ||
ember_app_name: "bar", | ||
) | ||
|
||
stylesheets = assets.stylesheets | ||
|
||
expect(stylesheets).to match_array([ | ||
"foo/assets/vendor", | ||
"foo/assets/bar", | ||
]) | ||
end | ||
end | ||
end | ||
end | ||
|
||
def build_assets(manifest: build_manifest, prefix: "assets", **options) | ||
EmberCli::Assets.new(options.merge(manifest: manifest, prefix: prefix)) | ||
end | ||
|
||
def build_manifest(files: {}) | ||
double(files: files) | ||
end | ||
|
||
def build_empty_manifest | ||
build_manifest | ||
end |