-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change allows ember-cli-rails to work under jruby-9.0.3.0 #241
Conversation
… a better fix for this
@softwareanimal thanks for the contribution! Keep in mind, Invoking Could you verify which invocation of |
app.rb near line 342 is the changed line, and where the error happens : The 'method_name' variable prints out as 'spawn' and 'method: :spawn' is passed in from app.rb near line 52 (not app.rb line 44 as I stated before): Not sure if this is related to the question. Again, I am not sure that you want to merge a change to support jruby-9.0.3.0. Also not sure what change you would merge. I just opened this pull request to report what worked under this environment and what does not work. |
@softwareanimal thanks for the context. I'll try looking into this and I'll ping you if I need more info. |
👍 |
Closes [#241]. Redirects `STDERR` to `STDOUT` via the `STDOUT` file descriptor (as described in the [`Kernel#spawn`][spawn] documentation). Related to [jruby/jruby#3038]. Covered by [ruby/rubyspec]. [#241]: #241 [spawn]: http://ruby-doc.org/core-2.2.3/Kernel.html#method-i-spawn [jruby/jruby#3038]: jruby/jruby#3038 [ruby/rubyspec]: https://github.com/ruby/rubyspec/blob/bfc40c3d73cc822e436b69b20967cf9b0eb7a4d8/shared/process/spawn.rb#L363-L369
@softwareanimal thank you so much for bringing this to our attention. A fix is being tracked in #288. Closing in favor of #288 |
Closes [#241]. Redirects `STDERR` to `STDOUT` via the `STDOUT` file descriptor (as described in the [`Kernel#spawn`][spawn] documentation). Related to [jruby/jruby#3038]. Covered by [ruby/rubyspec]. [#241]: #241 [spawn]: http://ruby-doc.org/core-2.2.3/Kernel.html#method-i-spawn [jruby/jruby#3038]: jruby/jruby#3038 [ruby/rubyspec]: https://github.com/ruby/rubyspec/blob/bfc40c3d73cc822e436b69b20967cf9b0eb7a4d8/shared/process/spawn.rb#L363-L369
@softwareanimal @nadavshatz could you please checkout the branch on #288 and give it a shot? |
Closes [#241]. No longer redirects `STDERR` to `STDOUT` via the `STDOUT` file descriptor (as described in the [`Kernel#spawn`][spawn] documentation). Related to [jruby/jruby#3038]. Uses `poltergeist` instead of `capybara-webkit`. Unfortunately, testing for `jruby` support is impossible until [thoughtbot/capybara-webkit#725][#725] is resolved. [#241]: #241 [spawn]: http://ruby-doc.org/core-2.2.3/Kernel.html#method-i-spawn [jruby/jruby#3038]: jruby/jruby#3038 [#725]: thoughtbot/capybara-webkit#725
Closes [#241]. No longer redirects `STDERR` to `STDOUT` via the `STDOUT` file descriptor (as described in the [`Kernel#spawn`][spawn] documentation). Related to [jruby/jruby#3038]. Uses `poltergeist` instead of `capybara-webkit`. Unfortunately, testing for `jruby` support is impossible until [thoughtbot/capybara-webkit#725][#725] is resolved. [#241]: #241 [spawn]: http://ruby-doc.org/core-2.2.3/Kernel.html#method-i-spawn [jruby/jruby#3038]: jruby/jruby#3038 [#725]: thoughtbot/capybara-webkit#725
There may be a better fix for this. I doubt that this change should be merged as it is.
Without this change, I get an error after running app.rb line 44:
@pid = exec(cmd, method: :spawn)
Using ruby-2.2.2 there is no problem. With 'rvm use jruby-9.0.3.0' the error is as follows :
Java::JavaLang::ArrayIndexOutOfBoundsException (-2):
org.jruby.util.io.PopenExecutor.run_exec_dup2(PopenExecutor.java:789)
org.jruby.util.io.PopenExecutor.execargRunOptions(PopenExecutor.java:986)
org.jruby.util.io.PopenExecutor.spawnProcess(PopenExecutor.java:113)
org.jruby.util.io.PopenExecutor.spawn(PopenExecutor.java:75)
org.jruby.RubyProcess.spawn(RubyProcess.java:1296)
org.jruby.RubyKernel.spawn(RubyKernel.java:1509)
...