Confirm addon is present in node_modules. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,7 +110,7 @@ def check_ember_cli_version! | |||
| end | |||
|
|
|||
| def check_addon! | |||
| unless dev_dependencies["ember-cli-rails-addon"] == ADDON_VERSION | |||
| unless addon_present | |||
There was a problem hiding this comment.
This should be addon_present?, right?
rwjblue
force-pushed
the
confirm-addon-present
branch
from
6a17354
to
a3818c5
Compare
|
👍 |
rwz
added a commit
that referenced
this pull request
Dec 23, 2014
Confirm addon is present in node_modules.
|
Small point of clarification... I'm assuming this navigates through package.json files through all deps making sure it's all good. This approach does not account for linked packages, so if you have a link to the correct version (on disk) but the package.json is wrong you'll get an error (even though it is correctly using the right version). Not a problem, and definitely the right behavior. But I ran into it just a few minutes ago, and it caused me some head scratching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #35.