Add support for detecting DEPRECATION: warnings #468
Conversation
| "DEPRECATION: A warning", | ||
| " at AStackTrace", | ||
| "", # Blank line | ||
| "SyntaxError: things went wrong" |
There was a problem hiding this comment.
Put a comma after the last item of a multiline array.
|
The CI failures on this PR are due to the fact that those specs are also broken on master - the specs are still testing Rails 3.2 but the code does not support it. I've created a separate PR to fix this: #469. |
|
Thx @mhaylock, my solution was not good enough? Can you explain a little more? |
|
Hi @victor95pc, thanks again for your solution. There are couple of problems it doesn't address, but would be simple enough to fix. Apologies if I've caused any offence by presenting my own solution. As you've requested further explanation I'll comment on your PR to clarify where I see there being some fixes required. |
|
No problem at all, I take about 30 minutes to create that solution, I didn't thought too much about all use cases, I just thought my solution was more clean but yours cover better all use cases, thanks for giving your time on this awesome project I love. . |
These warnings aren't build errors (the build is still successful), so we need to avoid treating such DEPRECATION lines as indicating a build error occured.
Address multiline array formatting issues highlighted by HoundCI.
mhaylock
force-pushed
the
deprecation-warning-detection
branch
from
6ccd156
to
e3eb29a
Compare
|
Thanks to @seanpdoyle merging #469 I've been able to rebase this PR and now the specs are passing. |
|
Excellent, thanks @seanpdoyle! |
These warnings aren't build errors (the build is still successful), so we need to avoid treating such
DEPRECATION:lines as indicating a build error occurred.This fixes #464 - a problem I've encountered with a new project using ember-cli-rails 0.7.4, Ember CLI 2.6.2 and ember-cli-rails-addon 0.7.0 (which is the source of the deprecation warning).
A different solution has been presented in PR #465 - this PR differs in that it will still detect build errors that occur even when a deprecation warning is present. It also ensures the build error files is still cleared between builds.
Thanks to @victor95pc for your work on #465 - it helped steer me in the right direction for fixing this :)
For the curious (because this is something I wondered myself) - the STDERR output of
ember buildis used to detect a build error instead of the exit status because in development mode the build is run with--watchand it never exits for there to be an exit status to assess.