Skip to content

Commit

Permalink
Value classes can be public
Browse files Browse the repository at this point in the history
These were originally private to prevent prefixes from leaking. We've
switched to handling prefixes in application config, so these can be
publicly accessible now.
  • Loading branch information
jferris committed Mar 29, 2019
1 parent 88b103e commit 1491cd1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/main/scala/fable/GroupId.scala
Expand Up @@ -6,7 +6,7 @@ import pureconfig.generic.semiauto.deriveReader
/**
* Value class for consumer group IDs.
*/
case class GroupId private (name: String) extends AnyVal
case class GroupId(name: String) extends AnyVal

object GroupId {
implicit val groupIdConfigReader: ConfigReader[GroupId] = deriveReader
Expand Down
4 changes: 1 addition & 3 deletions src/main/scala/fable/Topic.scala
Expand Up @@ -6,10 +6,8 @@ import pureconfig.generic.semiauto.deriveReader
/**
* Value class for topic names.
*/
case class Topic private (name: String) extends AnyVal
case class Topic(name: String) extends AnyVal

object Topic {
private[fable] def apply(name: String): Topic = new Topic(name)

implicit val topicConfigReader: ConfigReader[Topic] = deriveReader
}

0 comments on commit 1491cd1

Please sign in to comment.