Rubocop: Fix Layout/IndentHeredoc issues #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, that violation was probably removed as part of one of the other RuboCop PRs. Let's remove that TODO from the It also looks like we ended up with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the exclusionary line from the rubocop file, and then ran
rubocop -a.On visually inspecting the resulting output, I manually adjusted the offenses in
lint_specas the autocorrect did some weird things with it.I also took a look at the
Layout/SpaceInsideHashLiteralBracesTODO, and couldn't find the offense. Was it possibly fixed in a different PR? Can we remove that line from the rubocop file list?