Feature/improve file attributes #1327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: This is to add simple support to files on factories. This is the original [issue](#1282). What: It is a common behavior to interact with files when creating factories, and it is used heavily, as demonstrated with the many examples in the issue, this is a first draft and I would love to see more use-cases to add to the acceptance test. For the time being we have at least the base case added.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -1,3 +1,6 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| gemspec name: "factory_bot" | |||
|
|
|||
| gem 'pry' | |||
| gem 'activestorage' | |||
There was a problem hiding this comment.
Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem activestorage should appear before pry.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -1,3 +1,6 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| gemspec name: "factory_bot" | |||
|
|
|||
| gem 'pry' | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
- I am having a hard time on where to locate the method and have access to the method name and the instance so I can do something like: ```ruby file_loader = FileLoader.new() instance.send(method_name).attach( io: file_loader.io, filename: file_loader.filename ) ```
aledustet
force-pushed
the
feature/improve-file-attributes
branch
from
67c0f64
to
f113bc3
Compare
|
@aledustet what is the status of this draft? Are you still actively working on this, or should we close this for now? |
|
Going to close this for now since there hasn't been any activity for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am having a hard time on where to locate the method and have access
to the method name and the instance so I can do something like: