Allow to use AR class names as arguments to create, build etc #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +65,7 @@ def self.register_factory(factory) | |||
| end | |||
|
|
|||
| def self.factory_by_name(name) | |||
| name = name.to_s.underscore unless name.class.in? String, Symbol # looks like AR object | |||
There was a problem hiding this comment.
Thinking aloud here; @jferris and @joshuaclayton might have more ideas on this. How about if FactoryGirl::Registry's @items was a subclass of Hash that knew what to do with Class objects for keys.
class ClassyHash < Hash
def [](key)
super || super(key.to_s.underscore)
end
end
There was a problem hiding this comment.
There's actually a few decorators now - I think it'd make more sense there, actually, but I like that idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to discussion in c006dd1#commitcomment-1320334
As Object.make syntax is deprecated now, we need a way to pass classes to build/create methods. Currently you have to do
This commit allows to do
I never looked into FG internals, so please let me know if this patch should be modified or rewritten.