Fresh pass at displaying more detail during linting

[joshuaclayton]

Closes #692, #664, #696, #691

[jferris]

e => error ?

[joshuaclayton]

Changed in 896ae8b

[jferris]

Worth including the exception class name?

Looks good, generally. Ready to merge at your discretion.

[joshuaclayton]

@jferris the exception's class name could be valuable - especially if the message itself is ambiguous.

I've changed the output to:

* user
  ActiveRecord::RecordInvalid: Validation failed: Name can't be blank
* admin_user
  ActiveRecord::RecordInvalid: Validation failed: Name can't be blank

Thoughts?

[joshuaclayton]

maybe a parenthetical after the factory with the exception class name, with the message underneath?

* user (ActiveRecord::RecordInvalid)
  Validation failed: Name can't be blank
* admin_user (ActiveRecord::RecordInvalid)
  Validation failed: Name can't be blank

[jferris]

I'm guessing all on one line is generally okay. Would make it more convenient for things like grep anyway.

[silatham99]

This new behavior is inconsistent with the .lint documentation. Calling .create on any factory with dependent records is going to violate foreign key constraints.

[joshuaclayton]

@silatham99 I've updated docs to better reflect how linting operates.

The intention of Factory Girl is to be able to create data, so defined factories should in fact be able to be created.