Add coverage for JSON Schema V4 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
issue-88
branch
2 times, most recently
from
2b08d1f
to
225e8c0
Compare
houndci-bot
reviewed
Nov 2, 2018
musaffa
suggested changes
Nov 6, 2018
| "attributes" | ||
| ], | ||
| "properties": { | ||
| "id": { "type": "number" }, |
There was a problem hiding this comment.
@seanpdoyle The type of id should be "string". The test fails if we change the type from number to string.
seanpdoyle
commented
Nov 9, 2018
houndci-bot
reviewed
Nov 9, 2018
| @@ -59,6 +59,147 @@ | |||
| expect(json).to match_json_schema("api/v1/schema") | |||
| end | |||
|
|
|||
| it "supports invalidating the referenced schema when using local references" do | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [81/80]
musaffa
suggested changes
Nov 9, 2018
|
|
||
| json = build(:response, { | ||
| "data": [{ | ||
| "id": 1, |
There was a problem hiding this comment.
Convert this id attribute as a string, i.e. "id": "1". Keep the id inside the attributes as a number. The test will fail now.
|
This test will pass: it "Fails properly in local refs in referenced schema" do
create(:schema, name: "post", json: {
"$schema": "https://json-schema.org/draft-04/schema#",
"id": "file:/post.json#",
"definitions": {
"attributes": {
"type": "object",
"required": [
"id",
"name",
],
"properties": {
"id": { "type": "string" },
"name": { "type": "string" }
}
}
},
"type": "object",
"required": [
"id",
"type",
"attributes"
],
"properties": {
"id": { "type": "string" },
"type": { "type": "string" },
"attributes": {
# "$ref": "#/definitions/attributes"
"type": "object",
"required": [
"id",
"name",
],
"properties": {
"id": { "type": "string" },
"name": { "type": "string" }
}
}
}
})
posts_index = create(:schema, name: "posts/index", json: {
"$schema": "https://json-schema.org/draft-04/schema#",
"id": "file:/posts/index.json#",
"type": "object",
"required": [
"data"
],
"definitions": {
"posts": {
"type": "array",
"items": {
"$ref": "file:/post.json#"
}
}
},
"properties": {
"data": {
"$ref": "#/definitions/posts"
}
}
})
json = build(:response, {
"data": [{
"id": "1",
"type": "Post",
"attributes": {
"id": 1,
"name": "The Post's Name"
}
}]
})
expect(json).not_to match_json_schema(posts_index)
endBut this test will fail: it "Fails properly in local refs in referenced schema" do
create(:schema, name: "post", json: {
"$schema": "https://json-schema.org/draft-04/schema#",
"id": "file:/post.json#",
"definitions": {
"attributes": {
"type": "object",
"required": [
"id",
"name",
],
"properties": {
"id": { "type": "string" },
"name": { "type": "string" }
}
}
},
"type": "object",
"required": [
"id",
"type",
"attributes"
],
"properties": {
"id": { "type": "string" },
"type": { "type": "string" },
"attributes": {
"$ref": "#/definitions/attributes"
# "type": "object",
# "required": [
# "id",
# "name",
# ],
# "properties": {
# "id": { "type": "string" },
# "name": { "type": "string" }
# }
}
}
})
posts_index = create(:schema, name: "posts/index", json: {
"$schema": "https://json-schema.org/draft-04/schema#",
"id": "file:/posts/index.json#",
"type": "object",
"required": [
"data"
],
"definitions": {
"posts": {
"type": "array",
"items": {
"$ref": "file:/post.json#"
}
}
},
"properties": {
"data": {
"$ref": "#/definitions/posts"
}
}
})
json = build(:response, {
"data": [{
"id": "1",
"type": "Post",
"attributes": {
"id": 1,
"name": "The Post's Name"
}
}]
})
expect(json).not_to match_json_schema(posts_index)
endCheck out the difference in the commented out codes in |
|
@seanpdoyle any updates for this PR? |
Closes [#88]. Closes [#90]. Add tests from Issue #90 When the `"id"` key is specified as a `"number"` in both attribute and property definitions, then specified as a `"string"` value in the payload, the matcher will raise and the test will pass. After rebasing off `master` after [`3b66b4d`][3b66b4d] was merged, [the tests that were once failing][tests] are now passing. [#88]: #88 [#90]: #90 [3b66b4d]: 3b66b4d [tests]: #89 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88.
Closes #90.
Add tests from Issue #90
When the
"id"key is specified as a"number"in both attribute andproperty definitions, then specified as a
"string"value in thepayload, the matcher will raise and the test will pass.
After rebasing off
masterafter3b66b4dwas merged, thetests that were once failing are now passing.