Skip to content
This repository has been archived by the owner on Jun 8, 2019. It is now read-only.

I think that !! is not necessary. #54

Closed
wants to merge 1 commit into from
Closed

I think that !! is not necessary. #54

wants to merge 1 commit into from

Conversation

tapajos
Copy link
Contributor

@tapajos tapajos commented Sep 12, 2011

No description provided.

@gabebw
Copy link
Contributor

gabebw commented Sep 12, 2011

I actually prefer to return real booleans, rather than "something that isn't nil or false". Sorry!

@gabebw gabebw closed this Sep 12, 2011
@tapajos
Copy link
Contributor Author

tapajos commented Sep 12, 2011

Default value is false and if we change:

opts.on("-p", "--pretend", "Pretend mode: print what kumade would do") do |p|
    @options[:pretend] = p
end

for this

opts.on_tail("-p", "--pretend", "Pretend mode: print what kumade would do") do
    @options[:pretend] = true
end

We can remove "!!".

@options[:pretend] = p no make sense.

Can I change it?

@tapajos
Copy link
Contributor Author

tapajos commented Sep 12, 2011

Done. Close again if you think that I'm wrong.

@tapajos
Copy link
Contributor Author

tapajos commented Sep 12, 2011

Ops, I can't reopen this pull request.

@gabebw
Copy link
Contributor

gabebw commented Sep 12, 2011

Fair enough. Fixed it in ea5331d.

@tapajos
Copy link
Contributor Author

tapajos commented Sep 12, 2011

I pushed this code. I don't know why it is not here but it is in my branch.

Now I think that !! can be removed. Right?

@gabebw
Copy link
Contributor

gabebw commented Sep 12, 2011

Yep, I'll do that now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants