This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(feelsbadman) but the dependency on Bourbon was technically minimal. By removing the dependency on Bourbon we are able to gain more users and can potentially grow the community. resolves #346
- Loading branch information
Curt Howard
committed
Jun 16, 2016
1 parent
4bef318
commit 4415490
Showing
16 changed files
with
62 additions
and
75 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
@charset "UTF-8"; | ||
|
||
/// Provides an easy way to include a clearfix for containing floats. | ||
/// | ||
/// @link http://goo.gl/yP5hiZ | ||
/// | ||
/// @example scss | ||
/// .element { | ||
/// @include clearfix; | ||
/// } | ||
/// | ||
/// @example css | ||
/// .element::after { | ||
/// clear: both; | ||
/// content: ""; | ||
/// display: block; | ||
/// } | ||
@mixin clearfix { | ||
&::after { | ||
clear: both; | ||
content: ""; | ||
display: block; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
require "sass" | ||
require "bourbon" | ||
require "neat/generator" | ||
|
||
module Neat | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"name": "Neat", | ||
"description": "A lightweight, semantic grid framework built with Bourbon", | ||
"tags": ["bourbon", "columns", "grid", "layout", "media", "media-queries", "neat", "queries", "sass", "scss", "semantic"] | ||
"description": "A lightweight, semantic grid framework", | ||
"tags": ["columns", "grid", "layout", "media", "media-queries", "neat", "queries", "sass", "scss", "semantic"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
@import "bourbon/bourbon"; | ||
@import "../app/assets/stylesheets/neat"; | ||
$disable-warnings: true !global; |
4415490
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @meowsus,
this commit breaks gems depending on
neat
, for exampleadministrate
. Can't be fixed with a simplegem 'bourbon'
in the project's Gemfile, but must be fixed in theadministrate
gem itself.Shouldn't this change be in a major version bump (2.0 ?) where you can break backwards compatibility?
4415490
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clemensg This sounds like a bug with Administrate. Can you file an issue there?
4415490
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clemensg I agree with @clemensg. This does seem like a bug with the Administrate library.
Originally I had thought that this change would be breaking, and was surprised that it was actually released as a minor, but truthfully the functionality did not change and that would support the choice of releasing a minor and not a major version.
4415490
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Administrate only specifies Neat as a dependency, but not Bourbon (which it needs): https://github.com/thoughtbot/administrate/blob/master/administrate.gemspec#L22
Up until now, Neat brought in Bourbon which made this a non-issue. But that was fragile and now that Neat doesn’t explicitly declare Bourbon as a dependency, it’s broken.
Here’s a PR to Administrate to try and fix the problem: thoughtbot/administrate#614
4415490
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Removing a dependency which other projects depend upon implicitly, does qualify as a breaking change in my opinion, but) I'm also fine with fixing it in administrate.
Thank you for the quick responses and the pull request! 👍
4415490
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clemensg The problem is that Administrate directly uses Bourbon features, but never explicitly declared it as a dependency. It shouldn’t have assumed that Neat would always bring in the Bourbon library for it. It was fragile all along. Outside the context of Administrate, Neat no longer using Bourbon for one function isn’t a breaking change. The output is the same without that function.
4415490
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, sounds reasonable. Thanks for the explanation!