Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Make $column and $gutter not use modular-scale #346

Closed
kylefiedler opened this issue May 13, 2015 · 2 comments
Closed

Make $column and $gutter not use modular-scale #346

kylefiedler opened this issue May 13, 2015 · 2 comments
Milestone

Comments

@kylefiedler
Copy link
Contributor

The modular-scale functions are just complicating what is essentially a 3 to 1 ratio. Adding the function is unnecessarily complicating the code.

$column: 3em !default;
$gutter: 1em !default;
@tysongach
Copy link
Contributor

👍 There’s been chatter about decoupling Bourbon from Neat. There’s only a few small functions and mixins from Bourbon that Neat uses, all them are non-essential (related PR). Removing modular-scale would be trivial.

@kennethormandy
Copy link
Contributor

Really like this idea, and I’d be interested in helping. I was maintaining Straight Up, which was Neat without Bourbon, and it worked quite well. It’s nice to avoid the extra dependency if you’re using Autoprefixer.

@tysongach tysongach modified the milestone: 2.0 Feb 6, 2016
meowsus pushed a commit to meowsus/neat that referenced this issue Jun 3, 2016
(feelsbadman) but the dependency on Bourbon was technically minimal. By
removing the dependency on Bourbon we are able to gain more users and
can potentially grow the community.

resolves thoughtbot#346
meowsus pushed a commit to meowsus/neat that referenced this issue Jun 3, 2016
(feelsbadman) but the dependency on Bourbon was technically minimal. By
removing the dependency on Bourbon we are able to gain more users and
can potentially grow the community.

resolves thoughtbot#346
@whmii whmii closed this as completed in 4415490 Jun 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants