This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Add grid-shift mixin allowing for the reordering of columns
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,8 @@ | |||
| .box { | |||
| background-color: $color-neat-blue; | |||
| height: 30px; | |||
| min-height: 30px; | |||
There was a problem hiding this comment.
Properties should be ordered background-color, margin-bottom, min-height, padding
Prefer using placeholder selectors (e.g. %some-placeholder) with @extend
Closed
whmii
force-pushed
the
neat-2.0.0-grid-shift
branch
from
023dcf3
to
807b0fb
Compare
This was referenced Jul 18, 2016
Closed
whmii
force-pushed
the
neat-2.0.0-grid-shift
branch
from
807b0fb
to
49f1235
Compare
| @@ -1,7 +1,7 @@ | |||
| .grid-push--3 { | |||
| @include grid-push(3); | |||
| .grid-shift--4 { | |||
There was a problem hiding this comment.
Should this partial now be called _grid-shift.scss instead of _grid-push.scss?
There was a problem hiding this comment.
Wait…did you mean to make these changes in this partial?
Are they a dupe of _grid-shift.scss below?
There was a problem hiding this comment.
woops! good catch gach!
|
🎂 After that |
whmii
force-pushed
the
neat-2.0.0-grid-shift
branch
from
49f1235
to
f822823
Compare
whmii
force-pushed
the
neat-2.0.0-grid-shift
branch
from
f822823
to
51a45cb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using relative positioning of columns,
grid-shiftallows the user to move a grid column a specified number of columns to the right or left. This is distinct from thegrid-pushmixin in that push is better suited for positioning an object on the page while shift is better at reordering 2 or more grid objects. It should be said that shift also adds the relative positioning attribute.The following is an example image of the following markup: