This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Register Neat with asset pipeline when requisite #659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 13, 2018
| config.assets.paths << File.expand_path("../../core", __FILE__) | ||
| end | ||
| else | ||
| Sass.load_paths << File.expand_path("../../core", __FILE__) |
There was a problem hiding this comment.
Style/ExpandPathArguments: Use expand_path('../core', dir) instead of expand_path('../../core', FILE).
| module Neat | ||
| if defined?(Rails) && defined?(Rails::Engine) | ||
| class Engine < ::Rails::Engine | ||
| config.assets.paths << File.expand_path("../../core", __FILE__) |
There was a problem hiding this comment.
Style/ExpandPathArguments: Use expand_path('../core', dir) instead of expand_path('../../core', FILE).
There was a problem hiding this comment.
This validation message is a bit cryptic. I'm not seeing anything in the suggested use that will actually work.
composerinteralia
added a commit
that referenced
this pull request
Nov 9, 2018
Closes #659 I didn't realize this PR had already been opened by another Daniel. I changed a few little things, so I will merge this one instead with a co-author. Along the same lines as bourbon 8257c683f8, using `Sass.load_paths` won't work if we happen to be using sassc-rails instead of sass-rails. I ran into this when I was testing out thoughtbot/suspenders#936. Co-authored-by: Daniel Greenlaw <daniel@shirtspace.com>
|
Thanks! I opened a similar PR without realizing you had opened this one. Merged as a092ff7 with you listed as a co-author |
|
Oh hey, thanks for sharing the love. - Daniel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is entirely based on a recent change to Bourbon (commit 8257c6) that will register Neat with the Rails asset pipeline.
This resolves a compatibility issue with Sprockets 4 where the SASS processor source map does not include
Sass.load_paths.It may be the issue also lies in the Sprockets court given this is an incompatibility introduced in v4, which is still in beta. However, it may be worthwhile to account for it on this side too to maintain as much compatibility as possible.