Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Add Errno::EEXIST as possible exception that happens on linking #2532

Merged

Conversation

hron
Copy link
Contributor

@hron hron commented Jan 24, 2018

When I try to attach a file on Windows Paperclip fails on trying to make a link with Errno::EEXIST exception.
This exception should be caught as others inside Paperclip::AbstractAdapter#link_or_copy_file

@mike-burns
Copy link
Contributor

I've merged this without QA because I don't have access to a Windows computer easily, but to confirm: does this work? EEXIST seems like it means cp will also fail?

@hron
Copy link
Contributor Author

hron commented Jan 25, 2018

Yep, it works for me. I have stumbled upon this problem on a paperclip update and debug the problem. Everything works smoothly when this exceptions is caught.

@mike-burns
Copy link
Contributor

Thank you, @hron ! We'll release 5.2.1 shortly to fix this for everyone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants