Remove Rails 5.2 support (#82)

thoughtbot · Jul 1, 2023 · 7fdc814 · 7fdc814
1 parent 0551d18
commit 7fdc814
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 326 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,7 +22,6 @@ jobs:
         ruby:
           - 2.7.7
         appraisal:
-          - rails_5_2
           - rails_6_0
         test_framework:
           - minitest

diff --git a/Appraisals b/Appraisals
@@ -22,24 +22,6 @@ shared_dependencies = proc do
   instance_eval(&shared_test_dependencies)
 end
 
-appraise "rails_5_2" do
-  instance_eval(&shared_dependencies)
-
-  gem "rails", "~> 5.2.2"
-  gem "rails-controller-testing", ">= 1.0.1"
-  gem "puma", "~> 3.11"
-  gem "bootsnap", ">= 1.1.0", require: false
-  gem "sass-rails", "~> 5.0"
-  gem "turbolinks", "~> 5"
-  gem "jbuilder", "~> 2.5"
-  gem "bcrypt", "~> 3.1.7"
-  gem "capybara", "~> 3.1.1"
-  gem "selenium-webdriver"
-  gem "chromedriver-helper"
-  gem "listen", ">= 3.0.5", "< 3.2"
-  gem "spring-watcher-listen", "~> 2.0.0"
-end
-
 appraise "rails_6_0" do
   instance_eval(&shared_dependencies)
 

diff --git a/README.md b/README.md
@@ -161,7 +161,7 @@ may be of use:
 
 ## Compatibility
 
-Shoulda Context is [tested][travis] and supported against Ruby 2.7+, Rails 5.2+,
+Shoulda Context is [tested][travis] and supported against Ruby 2.7+, Rails 6.0+,
 Minitest 4.x, and Test::Unit 3.x.
 
 ## Versioning

diff --git a/gemfiles/rails_5_2.gemfile b/gemfiles/rails_5_2.gemfile
diff --git a/gemfiles/rails_5_2.gemfile.lock b/gemfiles/rails_5_2.gemfile.lock
diff --git a/test/shoulda/test_framework_detection_test.rb b/test/shoulda/test_framework_detection_test.rb
@@ -2,12 +2,6 @@
 require "tempfile"
 
 class TestFrameworkDetectionTest < PARENT_TEST_CASE
-  if Tests::CurrentBundle.instance.current_appraisal == "rails_5_2"
-    should "detect Minitest 5.x w/ Rails 5.2" do
-      assert_integration_with_rails_and "Minitest::Test"
-    end
-  end
-
   if TEST_FRAMEWORK == "minitest"
     should "detect Minitest 5.x when it is loaded standalone" do
       assert_integration_with "Minitest::Test", setup: <<-RUBY