Remove Rails 5.2 support #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
added a commit
to Earlopain/shoulda-context
that referenced
this pull request
Mar 1, 2024
The fix in rails was added somewhere in 5.X, thoughtbot#82 dropped support for rails 5.2, so just drop the workaround as well. ``` /usr/local/bundle/gems/shoulda-context-2.0.0/lib/shoulda/context/rails_test_unit_reporter_patch.rb:8: warning: method redefined; discarding old format_rerun_snippet /usr/local/bundle/gems/railties-7.1.3/lib/rails/test_unit/reporter.rb:76: warning: previous definition of format_rerun_snippet was here ```
vsppedro
pushed a commit
that referenced
this pull request
Mar 2, 2024
The fix in rails was added somewhere in 5.X, #82 dropped support for rails 5.2, so just drop the workaround as well. ``` /usr/local/bundle/gems/shoulda-context-2.0.0/lib/shoulda/context/rails_test_unit_reporter_patch.rb:8: warning: method redefined; discarding old format_rerun_snippet /usr/local/bundle/gems/railties-7.1.3/lib/rails/test_unit/reporter.rb:76: warning: previous definition of format_rerun_snippet was here ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.