Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Rails 5.2 support #82

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Remove Rails 5.2 support #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
ruby:
- 2.7.7
appraisal:
- rails_5_2
- rails_6_0
test_framework:
- minitest
Expand Down
18 changes: 0 additions & 18 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,24 +22,6 @@ shared_dependencies = proc do
instance_eval(&shared_test_dependencies)
end

appraise "rails_5_2" do
instance_eval(&shared_dependencies)

gem "rails", "~> 5.2.2"
gem "rails-controller-testing", ">= 1.0.1"
gem "puma", "~> 3.11"
gem "bootsnap", ">= 1.1.0", require: false
gem "sass-rails", "~> 5.0"
gem "turbolinks", "~> 5"
gem "jbuilder", "~> 2.5"
gem "bcrypt", "~> 3.1.7"
gem "capybara", "~> 3.1.1"
gem "selenium-webdriver"
gem "chromedriver-helper"
gem "listen", ">= 3.0.5", "< 3.2"
gem "spring-watcher-listen", "~> 2.0.0"
end

appraise "rails_6_0" do
instance_eval(&shared_dependencies)

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ may be of use:

## Compatibility

Shoulda Context is [tested][travis] and supported against Ruby 2.7+, Rails 5.2+,
Shoulda Context is [tested][travis] and supported against Ruby 2.7+, Rails 6.0+,
Minitest 4.x, and Test::Unit 3.x.

## Versioning
Expand Down
36 changes: 0 additions & 36 deletions gemfiles/rails_5_2.gemfile
View file
Open in desktop

This file was deleted.

264 changes: 0 additions & 264 deletions gemfiles/rails_5_2.gemfile.lock
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions test/shoulda/test_framework_detection_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@
require "tempfile"

class TestFrameworkDetectionTest < PARENT_TEST_CASE
if Tests::CurrentBundle.instance.current_appraisal == "rails_5_2"
should "detect Minitest 5.x w/ Rails 5.2" do
assert_integration_with_rails_and "Minitest::Test"
end
end

if TEST_FRAMEWORK == "minitest"
should "detect Minitest 5.x when it is loaded standalone" do
assert_integration_with "Minitest::Test", setup: <<-RUBY
Expand Down