Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments in validate_exclusion_of_matcher.rb #1273

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Update comments in validate_exclusion_of_matcher.rb #1273

merged 1 commit into from
Jan 17, 2020

Conversation

bino98
Copy link
Contributor

@bino98 bino98 commented Jan 17, 2020

fix comments

@bino98 bino98 changed the title Update validate_exclusion_of_matcher.rb Update validate_exclusion_of_matcher.rb comments Jan 17, 2020
@bino98 bino98 changed the title Update validate_exclusion_of_matcher.rb comments Update comments in validate_exclusion_of_matcher.rb Jan 17, 2020
@mcmire
Copy link
Collaborator

mcmire commented Jan 17, 2020

Oops, thank you!

@mcmire mcmire merged commit 0b49b57 into thoughtbot:master Jan 17, 2020
@bino98 bino98 deleted the patch-1 branch January 25, 2020 11:37
@guialbuk guialbuk mentioned this pull request Feb 5, 2020
Merged
guialbuk added a commit that referenced this pull request Feb 18, 2020
@guialbuk
Release version 4.3.0 (#1276)
321b87e 
### Features

* Add `have_rich_text` matcher for `ActionText` (#1263)

### Improvements
* Use range on `validate_exclusion_of#in_range` documentation (#1273)

### Bug fixes

* Fix `missing attribute:: scope 1` intermittent test:  (#1274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bino98 @mcmire