-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass correct object type to association reflection #992
Merged
mcmire
merged 1 commit into
thoughtbot:master
from
formigarafa:fix-association-relation
Jul 11, 2020
Merged
pass correct object type to association reflection #992
mcmire
merged 1 commit into
thoughtbot:master
from
formigarafa:fix-association-relation
Jul 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 11, 2017
spec/unit/shoulda/matchers/active_record/association_matchers/model_reflection_spec.rb
Outdated
Show resolved
Hide resolved
houndci-bot
reviewed
Jan 11, 2017
spec/unit/shoulda/matchers/active_record/association_matchers/model_reflection_spec.rb
Outdated
Show resolved
Hide resolved
houndci-bot
reviewed
Jan 11, 2017
spec/unit/shoulda/matchers/active_record/association_matchers/model_reflection_spec.rb
Outdated
Show resolved
Hide resolved
houndci-bot
reviewed
Jan 11, 2017
spec/unit/shoulda/matchers/active_record/association_matchers/model_reflection_spec.rb
Outdated
Show resolved
Hide resolved
mcmire
reviewed
Jan 12, 2017
spec/unit/shoulda/matchers/active_record/association_matchers/model_reflection_spec.rb
Outdated
Show resolved
Hide resolved
houndci-bot
reviewed
Jan 15, 2017
spec/unit/shoulda/matchers/active_record/association_matchers/model_reflection_spec.rb
Outdated
Show resolved
Hide resolved
I wrote another test before but it was duplicating most of the previous code, so I removed it. |
alyssais
added a commit
to alyssais/shoulda-matchers
that referenced
this pull request
Mar 12, 2017
…lation pass correct object type to association reflection
It's currently not possible to test a `has_many` association that is defined with a scope block where the block takes an instance of the association source. The `have_many` matcher attempts to call this scope and when it does so it does not pass that instance. This commit fixes that. Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Sorry for the delay in getting to this. I took the liberty of adding a missing test to this and cleaning up a couple things around the existing tests. This is merged now! |
@mcmire , I don't mind at all and I really appreciate that. Thanks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make the association relation receive the expected parameter
(a AR instance, not its class). fix #952