Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removed and gitignored Gemfile.lock and .bundle from the repository
- Loading branch information
Showing
3 changed files
with
2 additions
and
115 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,5 @@ pkg | |
*.swo | ||
tags | ||
tmp | ||
.bundle | ||
Gemfile.lock |
This file was deleted.
Oops, something went wrong.
304ad5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
Gemfile.lock
file is supposed to be checked into version control: http://gembundler.com/It's how you make sure that everybody is using the same versions to develop.
304ad5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Joe, For applications, yes; gem libraries, no. To handle picky versions with gem libraries, the versions should be declared as such in the gemspec.
See http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
304ad5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, Ryan - I didn't see that post.
304ad5b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Joe, With that said, if you want to tie down the development dependencies in the gemspec to something more concrete than using the
~>
operator, that seems reasonable. I should also mention that the commit following this one is necessary to see the whole picture. c7b35378