Update to Rails 5.2.0 #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 5.2.0 will give us ActiveStorage and all sorts of other goodies: http://edgeguides.rubyonrails.org/5_2_release_notes.html rails/rails#30016 introduced `Rails::AppBuilder#ruby_version` to create a .ruby_version file. To avoid getting stuck in an overwrite prompt when we try to create our own .ruby_version file based on `Suspenders::RUBY_VERSION`, I overrode `ruby_version`. Rails 5.2.0 adds bootsnap to the Gemfile and to config/boot.rb. I added it to our Gemfile, but we could also `skip_bootsnap` by default if we don't want to use it.
|
Looks like you're missing the addition of a few lines for bootsnap to work: |
|
@toobulkeh Rails 5.2 adds |
|
Merged as d3c2e89, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.2.0 will give us ActiveStorage and all sorts of other goodies:
http://edgeguides.rubyonrails.org/5_2_release_notes.html
rails/rails#30016 introduced
Rails::AppBuilder#ruby_versionto createa .ruby_version file. To avoid getting stuck in an overwrite prompt
when we try to create our own .ruby_version file based on
Suspenders::RUBY_VERSION, I overrode#ruby_version.Rails 5.2.0 adds bootsnap to the Gemfile and to config/boot.rb. I added it
to our Gemfile, but we could also
skip_bootsnapby default if we don'twant to use it.