Remove legacy trails #1221
Merged
Remove legacy trails #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r00k
force-pushed
the
bo-remove-legacy-trails
branch
from
e719f9d
to
b15721b
Compare
Closed
|
Still having a styling issue around colors. |
|
Ready for review. |
r00k
force-pushed
the
bo-remove-legacy-trails
branch
from
3248548
to
c494d91
Compare
| @@ -1,4 +1,4 @@ | |||
| body.resources-index { | |||
| body.topics.topics-show { | |||
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
There was a problem hiding this comment.
@ldamon Can you address the comment above por favor?
r00k
force-pushed
the
bo-remove-legacy-trails
branch
2 times, most recently
from
cb4621c
to
dbb2722
Compare
Once upon a time, Upcase had these things called trails.
They broke down a topic into a series of steps that could be completed.
They also linked to resources (made by thoughtbot and not) that would
help you learn a topic.
We liked these trails, but the only way to indicate you'd learned
something was to click a checkbox on a given step.
Later, we created our exercise system. After creating a handful of
unrelated exercises, we decided it would be better to create groups of
exercises to be completed in a given sequence.
We decided to call this grouping and sequencing a trail and renamed the
old trail concept legacy trails.
Having two things called "trail" at the same time was confusing, and the
legacy trails were the source of much criticism ("these are mostly links
to things outside Upcase!") We didn't like the code. Users were confused
and annoyed. Bad times.
This commit removes LegacyTrails and their associated baggage.
Now, "trail" means exactly one thing.
All is ✨ and 😂.
r00k
force-pushed
the
bo-remove-legacy-trails
branch
from
dbb2722
to
8eb7b70
Compare
| @@ -73,7 +73,7 @@ def included_in_current_users_plan?(licenseable) | |||
| helper_method :included_in_current_users_plan? | |||
|
|
|||
| def topics | |||
| Topic.top | |||
| Topic.all | |||
There was a problem hiding this comment.
I'm not 100% sure, but I think this should be explorable. If not, I think explorable can be removed entirely.
r00k
force-pushed
the
bo-remove-legacy-trails
branch
from
5405cb0
to
bcdfc53
Compare
This column isn't accurate and is actually unused (counts for a topic's resources are calculated in TopicWithResources).
r00k
force-pushed
the
bo-remove-legacy-trails
branch
from
bcdfc53
to
6c0d60a
Compare
This is necessary because we're calling `#count` on them. This used to work, probably accidentally, because there was a `count` column on Topic. Now, we want to use the `#count` method on TopicWithResource, so we need to decorate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time, Upcase had these things called trails.
They broke down a topic into a series of steps that could be completed.
They also linked to resources (made by thoughtbot and not) that would
help you learn a topic.
We liked these trails, but the only way to indicate you'd learned
something was to click a checkbox on a given step.
Later, we created our exercise system. After creating a handful of
unrelated exercises, we decided it would be better to create groups of
exercises to be completed in a given sequence.
We decided to call this grouping and sequencing a trail and renamed the
old trail concept legacy trails.
Having two things called "trail" at the same time was confusing, and the
legacy trails were the source of much criticism ("these are mostly links
to things outside Upcase!") We didn't like the code. Users were confused
and annoyed. Bad times.
This commit removes LegacyTrails and their associated baggage.
Now, "trail" means exactly one thing.
All is ✨ and 😂.