Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

Build Changeset on web-interface looks ugly on ruby1.9.1 #4

Open
evtuhovich opened this issue Jan 21, 2010 · 6 comments
Open

Build Changeset on web-interface looks ugly on ruby1.9.1 #4

evtuhovich opened this issue Jan 21, 2010 · 6 comments
Assignees
Labels
Milestone

Comments

@evtuhovich
Copy link

Build Changeset in web interface looks like this:

[SourceControl::Git::Revision:(0a9cbe11581ec160af7ac152746fc3d006b49244)]

Here a patch to fix it.

diff --git a/app/models/project.rb b/app/models/project.rb
index e1f86d4..8a1d15a 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -267,7 +267,7 @@ class Project
     begin
       if build_necessary?(reasons = [])
         remove_build_requested_flag_file if build_requested?
-        return build(source_control.latest_revision, reasons)
+        return build(source_control.latest_revision, reasons.flatten)
       else
         return nil
       end
@ghost ghost assigned bguthrie May 31, 2011
@bguthrie
Copy link
Contributor

I believe that this is still true. To fix soon.

@ywen
Copy link

ywen commented Jun 24, 2011

After pulled the the latest source. It seems to be fine with manually requested builds. But not the builds that triggered by an actual push

@ywen
Copy link

ywen commented Jun 24, 2011

Here's the screenshots:

same commit, the first one was triggered by the real commit:

http://cl.ly/0E3M2l2i3b0i3U3k053F

And this one is triggered manually:

http://cl.ly/2d3y0e1l3n313u3s1Y1g

Thanks

@bguthrie bguthrie reopened this Jun 25, 2011
@bguthrie
Copy link
Contributor

That's odd. Thanks very much for contributing the screenshots; I'll re-open.

@bguthrie
Copy link
Contributor

bguthrie commented Jul 3, 2011

I'm having a hard time replicating this; is anyone else seeing it?

@ywen
Copy link

ywen commented Jul 3, 2011

Just throw in more info: the env is ruby 1.9.2p136, hosted by nginx + passenger 3.0.7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants