Compile regexp's at build time. Use raw string literals for patterns … #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to avoid escaping
This avoids patterns like
"\\.id_rsa.*$"
, where the\
needs to be escaped such that Go's string interpreter correctly feeds\.id_rsa.*$
toregexp.MustCompile
(orregexp.Compile
).This improves legibility.
Note that in RE2,
\n
is still interpreted as a newline byregexp
, whereas prior to this PR, Go's string interpreter would have converted it to the newline character.There is also a minor optimization in
func NewIgnores
, that reuses thegroup
variable inside the loop, by definining it outside of thefor
.In theory, these changes will impact #152 positively.