Adding feature to ignore patterns/keywords #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR.
|
svishwanath-tw
approved these changes
Jul 24, 2020
|
Could I please request you to update README with this new feature as well? @steeve85 |
|
As this PR has already been merged, I will create a new PR today for the 2 changes that @svishwanath-tw requested and the README update. Thanks |
steeve85
added a commit
to steeve85/talisman
that referenced
this pull request
Jul 24, 2020
svishwanath-tw
pushed a commit
that referenced
this pull request
Jul 25, 2020
I have updated the README I added a Test for allowed pattern at the file and repository level I have updated the string used to replace allowed keywords I added omitempty option on FileIgnoreConfig.Checksum as I believe this is not a required parameter (This might need additional testing 👀 cc @svishwanath-tw @harinee )
harinee
pushed a commit
to harinee/talisman
that referenced
this pull request
Aug 9, 2020
* Adding feature to allow patterns
harinee
pushed a commit
to harinee/talisman
that referenced
this pull request
Aug 9, 2020
I have updated the README I added a Test for allowed pattern at the file and repository level I have updated the string used to replace allowed keywords I added omitempty option on FileIgnoreConfig.Checksum as I believe this is not a required parameter (This might need additional testing 👀 cc @svishwanath-tw @harinee )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on user feedback where Talisman was detecting some keyword frequently used like
key, I decided to look at the source code to see if we can add an allowed list of patterns/keywords to avoid having users ignoring file content detector for example.This appears to be a feature that other Talisman users are also interested to have if I refer to issue #39.
Based on this comment, I added the feature to allow keyword at the repository level and also at the file level.
.talismanrcfile can now look like this:Please let me know what you think of this MVP version of the feature. I can improve it based on your feedback and add unit tests too.