Allow Keyword - PR #213 followup #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svishwanath-tw
approved these changes
Jul 25, 2020
|
When is your next release scheduled for? |
harinee
pushed a commit
to harinee/talisman
that referenced
this pull request
Aug 9, 2020
I have updated the README I added a Test for allowed pattern at the file and repository level I have updated the string used to replace allowed keywords I added omitempty option on FileIgnoreConfig.Checksum as I believe this is not a required parameter (This might need additional testing 👀 cc @svishwanath-tw @harinee )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to follow up on #213
omitemptyoption on FileIgnoreConfig.Checksum as I believe this is not a required parameter (This might need additional testing 👀 cc @svishwanath-tw @harinee )