Disable tty pass through to talisman binary in pre-push hook mode #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svishwanath-tw
force-pushed
the
pre-push-fix
branch
from
df8a1cc
to
af7d177
Compare
|
Hope you have done manual testing |
dineshba
approved these changes
Sep 7, 2020
derwent-m
reviewed
Sep 8, 2020
Comment on lines
-82
to
+85
| [[ $(toLower "${TALISMAN_INTERACTIVE}") == "true" ]] && INTERACTIVE="-i" | ||
| if [ $(toLower "${TALISMAN_INTERACTIVE}") == "true" ]; then | ||
| INTERACTIVE="-i" | ||
| [[ "${HOOKNAME}" == "pre-commit" ]] && exec < /dev/tty || echo_warning "talisman pre-push hook cannot be invoked in interactive mode currently" | ||
| fi |
There was a problem hiding this comment.
Hey there, just noticed that since you've change the [[ ... ]] to if [ ... ], $(toLower "${TALISMAN_INTERACTIVE}") now needs to be quoted, otherwise you will get
.git/hooks/bin/pre-commit: line 82: [: ==: unary operator expectedif $TALISMAN_INTERACTIVE is not set.
Easy mistake to make :P
if [ "$(toLower "$TALISMAN_INTERACTIVE")" == "true" ]; thendoes the trick!
derwent-m
pushed a commit
to derwent-m/talisman
that referenced
this pull request
Sep 8, 2020
svishwanath-tw
pushed a commit
that referenced
this pull request
Sep 8, 2020
…249) * [Resolves #170] Add pre-commit option in install.sh * [Issue #247] update VERSION and SHAs to v1.8.0 * [Issue #247] download talisman_hook_script.bash along with talisman into .git/hooks/bin * [Issue #247] 🚨 Fix shellcheck warnings * [Issue #247] 📝 update doc, single project install * 📝 fix inaccuracy in documentation * 🐛 Handle bug introduced in #246 Co-authored-by: derwentx <derwentx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git refs sent via stdin to hook script are lost with
exec </dev/tty