Extracting Configurations

app/mailers/candidate_mailer.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 class CandidateMailer < ActionMailer::Base
-  default from: "sistema@votocomovamos.com.br"
+  default from: Settings.email_sender
 
   def claim(candidate_id)
     @candidate = Candidate.find(candidate_id)

config/application.yml

@@ -2,6 +2,12 @@ common:
   facebook_scopes: "offline_access,read_stream,email"
   heroku_app_url: "http://voto-como-vamos.herokuapp.com"
   facebook_permission_request_url: "http://www.facebook.com/connect/uiserver.php"
+  email_sender: "sistema@votocomovamos.com.br"
+  exception_sender: "noreply@votocomovamos.com.br"
+  exception_recipient: "votocomovamos@thoughtworks.com"
+  fqdn: "www.votocomovamos.com.br"
+  mailtrap_io_user: "votocomovamos"
+  mailtrap_io_password: "7abaf1e52c5bc55d"
 
 development:
   facebook_app_id: 342716239136799
@@ -16,6 +22,7 @@ test:
 staging:
   facebook_app_id: 250842391695084
   facebook_app_url: "http://apps.facebook.com/250842391695084"
+  fqdn: "teste.votocomovamos.com.br"
 
 production:
   facebook_app_id: 502204129793230

config/environment.rb

@@ -1,5 +1,7 @@
 # Load the rails application
 require File.expand_path('../application', __FILE__)
 
+require File.expand_path('../settings', __FILE__)
+
 # Initialize the rails application
 VotoComoVamos::Application.initialize!

config/environments/development.rb

@@ -41,8 +41,8 @@
 
   ActionMailer::Base.delivery_method = :smtp
   ActionMailer::Base.smtp_settings = {
-      :user_name => "votocomovamos",
-      :password => "7abaf1e52c5bc55d",
+      :user_name => Settings.mailtrap_io_user,
+      :password => Settings.mailtrap_io_password,
       :address => "mailtrap.io",
       :port => 2525,
       :authentication => :plain

config/environments/production.rb

@@ -64,22 +64,22 @@
   # Log the query plan for queries taking more than this (works
   # with SQLite, MySQL, and PostgreSQL)
   # config.active_record.auto_explain_threshold_in_seconds = 0.5
-  config.action_controller.asset_host = "http://www.votocomovamos.com.br"
-  config.action_mailer.asset_host = "http://www.votocomovamos.com.br"
+  config.action_controller.asset_host = "http://#{Settings.fqdn}"
+  config.action_mailer.asset_host = "http://#{Settings.fqdn}"
   config.action_mailer.default_url_options = {
-    :host => "www.votocomovamos.com.br"
+    :host => Settings.fqdn
   }
   ActionMailer::Base.smtp_settings = {
     :port           => ENV['MAILGUN_SMTP_PORT'],
     :address        => ENV['MAILGUN_SMTP_SERVER'],
     :user_name      => ENV['MAILGUN_SMTP_LOGIN'],
     :password       => ENV['MAILGUN_SMTP_PASSWORD'],
-    :domain         => 'www.votocomovamos.com.br',
+    :domain         => Settings.fqdn,
     :authentication => :plain,
   }
   ActionMailer::Base.delivery_method = :smtp
 
   config.middleware.use ExceptionNotifier,
-    sender_address: 'noreply@votocomovamos.com.br',
-    exception_recipients: 'votocomovamos@thoughtworks.com'
+    sender_address: Settings.exception_sender
+    exception_recipients: Settings.exception_recipient
 end

config/environments/staging.rb

@@ -64,16 +64,16 @@
   # Log the query plan for queries taking more than this (works
   # with SQLite, MySQL, and PostgreSQL)
   # config.active_record.auto_explain_threshold_in_seconds = 0.5
-  config.action_mailer.asset_host = "http://teste.votocomovamos.com.br"
+  config.action_mailer.asset_host = "http://#{Settings.fqdn}"
   config.action_mailer.default_url_options = {
-    :host => "teste.votocomovamos.com.br"
+    :host => Settings.fqdn
   }
   ActionMailer::Base.smtp_settings = {
     :port           => ENV['MAILGUN_SMTP_PORT'],
     :address        => ENV['MAILGUN_SMTP_SERVER'],
     :user_name      => ENV['MAILGUN_SMTP_LOGIN'],
     :password       => ENV['MAILGUN_SMTP_PASSWORD'],
-    :domain         => 'teste.votocomovamos.com.br',
+    :domain         => Settings.fqdn,
     :authentication => :plain,
   }
   ActionMailer::Base.delivery_method = :smtp