Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: How client and server interact during poll #33

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

stappersg
Copy link
Contributor

The iPXE client just repeats the same request, a.k.a. "polling". It is the Shoelaces server that can break the polling loop. Either by handing out automated boot entry point based on IP address or DNS PTR record, hand picked boot entry point from Web UI or due retry maximum reached.

Signed-off-by: Geert Stappers stappers@stappers.it

The iPXE client just repeats the same request, a.k.a. "polling".
It is the Shoelaces server that can break the polling loop.
Either by handing out automated boot entry point based on IP address
or DNS PTR record,  hand picked boot entry point from Web UI
or due retry maximum reached.

Signed-off-by: Geert Stappers <stappers@stappers.it>
@stappersg
Copy link
Contributor Author

The original string_changes patch had

# FYI: For the iPXE client is the above an endless loop,
#      but it is the shoelaces server that decides if it loops.

as informational text for the sysadmin that is reviewing Shoelaces.

This patch is for replacing the

# However, Shoelaces will break that loop after a fixed number of retries.

with a more generic the server is in control.

@raul-te raul-te merged commit 8b80016 into thousandeyes:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants