Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process .js files with babel also, fixes issue with const in dist/rst2html.min.js #1

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

DanCech
Copy link
Contributor

@DanCech DanCech commented Dec 13, 2017

The dist/rst2html.min.js file currently contains a const declaration, which causes issues when included in es5 projects.

This PR modifies the webpack config so that .js files are run through babel as well as .jsx, so that the output file contains valid es5.

@thoward thoward merged commit d6e2f21 into thoward:master Dec 13, 2017
@thoward
Copy link
Owner

thoward commented Dec 13, 2017

Looks good! Thanks so much for the contribution. I'm just getting started with this project, so there's a lot of loose ends. :)

@DanCech
Copy link
Contributor Author

DanCech commented Dec 13, 2017

Happy to help out where I can! I'm looking to use it to integrate function documentation for http://graphiteapp.org/ functions into the UI in https://grafana.com/grafana, you can follow progress at grafana/grafana#10139 if you're interested.

@thoward
Copy link
Owner

thoward commented Dec 13, 2017

Great! I'll follow along.

One thing to note: This project depends on the parser at https://github.com/seikichi/restructured , which itself is only partially implemented. There are a number of kinds of RST content that are not handled by the parser at all... So, for this renderer to get much better than it is, we'd need to make investments into the parser project.

My next task here will be documenting the code, adding more detailed unit tests, and figuring out where the gaps are in terms of what the parser covers, and what the renderer covers. I also think I'm going to change how the API works, and return a walkable structured tree of tags, with a separate stringify-ing stage, so that things like indents are easier to manage, and to allow folks to walk the tree and add attributes/css classes etc.

@DanCech
Copy link
Contributor Author

DanCech commented Dec 21, 2017

any chance you could release 1.0.5?

@thoward
Copy link
Owner

thoward commented Jan 5, 2018

@DanCech I can cut a new release today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants